Handoff — Auto-mode deepeners (2026-07-24)¶
Reviewed 2026-08-11 (issue #137). Eight defects found and fixed; see the "Frontier review pass" table in TRACKING.md and
tests/unit/test_review_hardening_137.py. Built under Auto mode after fable-5 token limit; skipped deep testing / code review / live setup.
Context¶
Roadmap v2 trains F1–F5 landed on main via PRs #124–#134 (+ #126/#129/#131/#133).
This branch/commit deepens tracer-bullet areas that were thin:
| Slice | What landed | Review focus |
|---|---|---|
| Periodic org policy sync | daari/enterprise/policy_sync.py; hooked into AppContext.start_org_learning_sync when enterprise.policy_sync_url is set |
Signature failure modes; concurrent apply vs in-flight requests; whether persist should default on |
| Config editor persist | PATCH /v1/daari/config accepts persist: true → daari/config/persist.py writes ~/.daari/config.yaml |
Path injection / partial merge correctness; race with Settings.load |
| D4 defaults proposal | daari learn propose-defaults + daari/learning/propose_defaults.py |
Heuristic quality; schema vs real build_collective_stats output; never auto-promote |
| Web UI config panel | packages/web-ui Load/Save for confidence / prefer / daily budget |
Auth headers when server.api_key set; disabled-state UX; no SSO token field yet |
| Docs | CHANGELOG Unreleased + this handoff | Accuracy vs git history |
Explicitly NOT done (user-gated / next-month)¶
- PyPI upload — needs
PYPI_API_TOKENin repo secrets; cut 1.2.x or 1.3.0. - Homebrew sha256 — fill
Formula/daari.rbafter release tarball exists. - Real OIDC — done (#136 / PR #140); HMAC retained for local/dev.
- Redis L1 semantic — done (#135 / PR #139).
- Live Postgres / Redis E2E — done (#142);
docker compose --profile backends+scripts/smoke_backends.sh(skips if Docker down). - Config editor auth in web-ui — done (#141); toolbar Bearer field +
localStorage. - Full suite + live E2E — intentionally skipped this pass; run default pytest + daemon smoke before shipping a release.
- D4 promotion — proposals under
~/.daari/proposals/must stay review-gated.
Review checklist — completed 2026-08-11 (#137)¶
- [x]
pytest -m "not integration and not benchmark" -qgreen (669 passed) - [x] Config editor PATCH with/without
persist— now validates first (400 on bad input) and writes atomically at 0600 - [x]
enterprise.policy_sync_urlloop — now fails closed without a signing secret, refuses plaintext URLs, and no longer blocks the event loop - [x]
daari learn propose-defaults— was silently emitting empty proposals against the realexport-statsschema; fixed - [x] Web UI config card with and without API key / SSO — covered by #141 tests
- [x] Security pass on persist + policy_sync (YAML merge, HMAC, admin role)
- [ ] Decide 1.3.0 scope: Redis L1, real OIDC, ghcr publish, PyPI
How to resume¶
git checkout main && git pull
# or the PR branch from this deepen commit
source .venv/bin/activate
pip install -e ".[dev]"
pytest -m "not integration and not benchmark" -q
Open issues: prefer new auto-dev issues labeled needs-review for items 3–8 above rather than expanding this handoff.